Override resultNow and exceptionNow in AbstractFuture.#8249
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 7, 2026
Merged
Override resultNow and exceptionNow in AbstractFuture.#8249copybara-service[bot] merged 1 commit intomasterfrom
resultNow and exceptionNow in AbstractFuture.#8249copybara-service[bot] merged 1 commit intomasterfrom
Conversation
For users on Java 19+ who could already call those methods on any `Future`, this CL just means that they'll get a faster implementation. For users before Java 19, this adds the methods to the API—but only to the API of `AbstractFuture` and its subclasses, `SettableFuture` and `FluentFuture`, not to `ListenableFuture` in general. I'm going to tentatively say that this fixes #8245, but anyone is free to let us know if you'd like to see more in that area, whether by reopening the issue or opening a new one. As an additional step toward handling `resultNow`, `exceptionNow`, and even `state`, I've also copied our standard warnings about forwarding objects (including `default` methods) into the `Forwarding*Future` family, including the package-private `ForwardingFluentFuture`. RELNOTES=n/a PiperOrigin-RevId: 880109858
copybara-service
bot
force-pushed
the
test_879645641
branch
from
d52fac9 to
5eaaff8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override
resultNowandexceptionNowinAbstractFuture.For users on Java 19+ who could already call those methods on any
Future, this CL just means that they'll get a faster implementation.For users before Java 19, this adds the methods to the API—but only to the API of
AbstractFutureand its subclasses,SettableFutureandFluentFuture, not toListenableFuturein general.I'm going to tentatively say that this fixes #8245, but anyone is free to let us know if you'd like to see more in that area, whether by reopening the issue or opening a new one.
As an additional step toward handling
resultNow,exceptionNow, and evenstate, I've also copied our standard warnings about forwarding objects (includingdefaultmethods) into theForwarding*Futurefamily, including the package-privateForwardingFluentFuture.RELNOTES=n/a