Short-circuit TypeToken#equals for same instance comparison#8427
Closed
kilink wants to merge 1 commit into
Closed
Conversation
Avoid delegating to the runtime type's equals implementation in TypeToken#equals for identical instances of TypeTokens.
cpovirk
added
type=enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid delegating to the runtime type's equals implementation in TypeToken#equals for identical instances of TypeTokens.
Depending on the implementation of
Type, the equals method forruntimeTypecan be somewhat costly (e.g., triggering array cloning forParameterizedType, etc). We actually have a scenario where cachedTypeTokeninstances are often compared, and our equals implementation forParameterizedTypewas less than ideal and showed up on some performance traces. I've fixed that as well, but TypeToken may as well avoid the call altogether if it can.