Modernize cancellation configuration. - #1943
Merged
Merged
Conversation
3517379 probably used the best tools available in 2022. But this PR's approach, which we've been using with success [in Guava](https://github.com/google/guava/blob/0adf237b742d899d00239dfeefdd42807ff46a83/.github/workflows/ci.yml#L14-L17) and in other projects, looks to be [the recommended approach](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-using-a-fallback-value) nowadays. In particular, I wonder if the current setup is over-canceling: Currently, I see reports like ["Canceling since a higher priority waiting request for ci-main-b7c7483a46afadd43a2f04935aaee5ff0cd09145 exists"](https://github.com/google/guice/actions/runs/30832661591/job/91750157428) on a large number of jobs, causing GitHub to report the overall CI status as "failure." RELNOTES=n/a PiperOrigin-RevId: 958535716
copybara-service
Bot
force-pushed
the
test_958502207
branch
from
August 3, 2026 20:07
555dba8 to
621416a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize cancellation configuration.
3517379 probably used the best tools available in 2022. But this PR's approach, which we've been using with success in Guava and in other projects, looks to be the recommended approach nowadays.
In particular, I wonder if the current setup is over-canceling: Currently, I see reports like "Canceling since a higher priority waiting request for ci-main-b7c7483a46afadd43a2f04935aaee5ff0cd09145 exists" on a large number of jobs, causing GitHub to report the overall CI status as "failure."
RELNOTES=n/a