runsc: don't forward GOMAXPROCS environment variable to fsgofers #12271
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl827638880
branch
2 times, most recently
from
d67dc60 to
889f6a0
Compare
This is not strictly required for runsc-sandbox since runsc/boot/loader.go:New() unconditionally overrides the default GOMAXPROCS via a call to gomaxprocs.SetBase(). Alternatively, we could filter out the GOMAXPROCS environment variable from all shim invocations of runsc (in e.g. pkg/shim/v1/runsccmd/runsc.go:runsccmd.Runsc.command()). But since said invocations of runsc run in containerd's cgroups and are thus subject to its resource restrictions, it's not clear that this would be better. PiperOrigin-RevId: 828079033
copybara-service
bot
force-pushed
the
test/cl827638880
branch
from
889f6a0 to
fec04fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runsc: don't forward GOMAXPROCS environment variable to fsgofers
This is not strictly required for runsc-sandbox since
runsc/boot/loader.go:New() unconditionally overrides the default GOMAXPROCS via
a call to gomaxprocs.SetBase().
Alternatively, we could filter out the GOMAXPROCS environment variable from all
shim invocations of runsc (in e.g.
pkg/shim/v1/runsccmd/runsc.go:runsccmd.Runsc.command()). But since said
invocations of runsc run in containerd's cgroups and are thus subject to its
resource restrictions, it's not clear that this would be better.