Skip to content

runsc: don't forward GOMAXPROCS environment variable to fsgofers #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
+5 −0
Merged

runsc: don't forward GOMAXPROCS environment variable to fsgofers #12271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions runsc/container/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"os/exec"
"path"
"regexp"
"slices"
"strconv"
"strings"
"syscall"
Expand Down Expand Up @@ -1309,6 +1310,10 @@ func (c *Container) createGoferProcess(conf *config.Config, mountHints *boot.Pod

// Start with the general config flags.
cmd := exec.Command(specutils.ExePath, conf.ToFlags()...)
// Don't forward GOMAXPROCS defaults that apply to this process (in
// particular, containerd-shim-runsc-v1 passes GOMAXPROCS=2 in
// v1.service.newCommand()).
cmd.Env = slices.DeleteFunc(os.Environ(), func(env string) bool { return strings.HasPrefix(env, "GOMAXPROCS=") })
cmd.SysProcAttr = &unix.SysProcAttr{
// Detach from session. Otherwise, signals sent to the foreground process
// will also be forwarded by this process, resulting in duplicate signals.
Expand Down
Loading