Fix TSan data race in UDP Socket Tests - #13875
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test/cl954957961
branch
4 times, most recently
from
July 28, 2026 21:14
32a883b to
55a7f36
Compare
TSan flags concurrent socket operations on the identical host FD as a data race. This commit uses dup() to duplicate the socket file descriptor specifically for the background thread's connect() call, so sendto and connect can execute concurrently from two different threads without TSan data race on the fd struct. PiperOrigin-RevId: 955479183
copybara-service
Bot
force-pushed
the
test/cl954957961
branch
from
July 28, 2026 21:42
55a7f36 to
87dc2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TSan data race in UDP Socket Tests
TSan flags concurrent socket operations on the identical host FD
as a data race. This commit uses dup() to duplicate the socket file
descriptor specifically for the background thread's connect() call,
so sendto and connect can execute concurrently from two different
threads without TSan data race on the fd struct.