runsc: Add --shared-root to share control files across the system. - #13978
Open
EtiennePerot wants to merge 1 commit into
Open
runsc: Add --shared-root to share control files across the system.#13978EtiennePerot wants to merge 1 commit into
runsc: Add --shared-root to share control files across the system.#13978EtiennePerot wants to merge 1 commit into
Conversation
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91.
konstantin-s-bogom
approved these changes
Aug 4, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
`--root` is the OCI parameter for the control directory for sandboxes. `--shared-root` defaults to that, but can be specified separately. Semantically, the distinction is that having access to `--root` gives you full control over the sandboxes with that `--root`, whereas access to `--shared-root` only gives you the ability to identify and list sandboxes using that `--shared-root`, but no control over them. It is used to put the `null-netns` control file, which is safe to reuse across sandboxes. This allows systems such as Substrate, which specify a separate `--root` per sandbox, to still benefit from the shared `null` netns speedup introduced in 4164f91. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13978 from EtiennePerot:shared-root 517d4fb PiperOrigin-RevId: 959077210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--rootis the OCI parameter for the control directory for sandboxes.--shared-rootdefaults to that, but can be specified separately.Semantically, the distinction is that having access to
--rootgives you full control over the sandboxes with that--root, whereas access to--shared-rootonly gives you the ability to identify and list sandboxes using that--shared-root, but no control over them.It is used to put the
null-netnscontrol file, which is safe to reuse across sandboxes.This allows systems such as Substrate, which specify a separate
--rootper sandbox, to still benefit from the sharednullnetns speedup introduced in 4164f91.