runsc: allow readv for direct TAP links - #14232
Open
tianyuzhou95 wants to merge 1 commit into
Open
Conversation
Allow the sentry to use readv when an fdbased endpoint receives a non-socket file descriptor such as a TAP or TUN device. The dispatcher already selects readv for these supported descriptors, but the common seccomp policy previously terminated the sentry on its first packet. This keeps the seccomp policy aligned with the existing fdbased receive path used by direct TAP links. Signed-off-by: Tianyu Zhou <albert.zty@antgroup.com>
Contributor
Author
|
Friendly ping @konstantin-s-bogom @nybidari — when you have a chance, could you please take a look at this? |
konstantin-s-bogom
approved these changes
Aug 27, 2026
konstantin-s-bogom
left a comment
konstantin-s-bogom
left a comment
Member
There was a problem hiding this comment.
Yeah it looks OK, we already allow readv and preadv2 so this shouldn't increase the exposed host surface area.
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Allow the sentry to use readv when an fdbased endpoint receives a non-socket file descriptor such as a TAP or TUN device. The dispatcher already selects readv for these supported descriptors, but the common seccomp policy previously terminated the sentry on its first packet. This keeps the seccomp policy aligned with the existing fdbased receive path used by direct TAP links. FUTURE_COPYBARA_INTEGRATE_REVIEW=#14232 from tianyuzhou95:albert/readv-seccomp bb9b1dd PiperOrigin-RevId: 971992510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the sentry to use readv when an fdbased endpoint receives a non-socket file descriptor such as a TAP or TUN device. The dispatcher already selects readv for these supported descriptors, but the common seccomp policy previously terminated the sentry on its first packet.
This keeps the seccomp policy aligned with the existing fdbased receive path used by direct TAP links.