add initial support for --tmp-mount flag - #14553
Open
andrewsykim wants to merge 2 commits into
Open
Conversation
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
adi-IL
reviewed
Sep 2, 2026
adi-IL
left a comment
adi-IL
left a comment
There was a problem hiding this comment.
Tested locally on Linux x86_64.
Exposing --tmp-mount (auto, tmpfs, rootfs) in runsc/config gives containers control over /tmp mounting behavior. In mountTmp (runsc/boot/vfs.go), honoring rootfs avoids shadowing pre-populated /tmp directories from container layers, while tmpfs forces an in-memory tmpfs mount even when /tmp contains existing files. Flag parsing and spec configuration tests in specutils_test.go pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14474