Add RNSPolynomial constant folding#3135
Merged
Merged
Conversation
crockeea
approved these changes
Jun 26, 2026
crockeea
left a comment
crockeea
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Does this mean that I can now attempt removal of the special cases for constants (and the special case of the PolyToModArith lowering) in PolyMulToNTT?
Collaborator
I think I have lost the mental thread on what exactly the blocker was here, but if you try this, you would need to either:
Since we haven't done a ton of constant folding in HEIR yet, I'm not sure which will be the cleanest for your purposes. |
copybara-service
Bot
force-pushed
the
test_938805181
branch
3 times, most recently
from
June 29, 2026 19:38
ea603c5 to
71a632e
Compare
This change supports ops: - add - sub - mul - ntt - intt - extract_slice I explicitly fail if the NTT/iNTT ops don't have an attached primitive root. I think this is correct because if the RNSPolynomialAttrs are in evaluation form already as input to the folder, it is invalid to combine such polynomials. So applying folding here requires all ntt/intt ops that could cause two polynomials in evaluation form to be folded together to use the same primitive root. PiperOrigin-RevId: 939980273
copybara-service
Bot
force-pushed
the
test_938805181
branch
from
June 29, 2026 19:51
71a632e to
b122e4a
Compare
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RNSPolynomial constant folding
This change supports ops:
I explicitly fail if the NTT/iNTT ops don't have an attached primitive root. I think this is correct because if the RNSPolynomialAttrs are in evaluation form already as input to the folder, it is invalid to combine such polynomials. So applying folding here requires all ntt/intt ops that could cause two polynomials in evaluation form to be folded together to use the same primitive root.