Skip to content

Ignore SysctlChanged condition when using kf doctor #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakweg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ignore SysctlChanged condition when using kf doctor #1106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3dfe3b
Ignore SysctlChanged condition when using `kf doctor`
jakweg May 6, 2026
8ddad6a
Generalize condition ignorance
jakweg May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkg/kf/doctor/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,11 @@ func diagnoseDaemonSets(ctx context.Context, d *Diagnostic, kubernetes kubernete
}
}

func conditionShouldBeIgnored(condition corev1.NodeCondition) bool {
shouldIgnore := condition.Type == "SysctlChanged" && condition.Status != corev1.ConditionFalse && condition.Message == "{\"unmanaged\": {\"kernel.cad_pid\": \"1\"}}"
return shouldIgnore
}

func diagnoseNodes(ctx context.Context, d *Diagnostic, kubernetes kubernetes.Interface) {
nodesList, err := kubernetes.CoreV1().Nodes().List(ctx, metav1.ListOptions{})
switch {
Expand Down Expand Up @@ -501,9 +506,9 @@ func diagnoseNodes(ctx context.Context, d *Diagnostic, kubernetes kubernetes.Int
)
}
default:
// Other conditions on the node should be false because they
// indicate specific failure conditions when set to true.
if cond.Status != corev1.ConditionFalse {
// Other conditions on the node should be false (unless known issue)
// because they indicate specific failure conditions when set to true.
if cond.Status != corev1.ConditionFalse && !conditionShouldBeIgnored(cond) {
d.Errorf(
"Condition %s is not healthy, current status is %q with message %q",
cond.Type,
Expand Down
Loading