Consume all Kotlin sources in KSP to support other code generators#3001
Merged
Conversation
hfmehmed
force-pushed
the
consumer-all-kotlin-sources
branch
from
0a2a87b to
b4102b5
Compare
jaschdoc
reviewed
Jun 24, 2026
jaschdoc
left a comment
jaschdoc
left a comment
Collaborator
There was a problem hiding this comment.
Before I approve, could you provide some more context as to what the issue is (in addition to the fact that KSP doesn't pick up sources generated by in other ways than KSP)? :)
hfmehmed
force-pushed
the
consumer-all-kotlin-sources
branch
from
b4102b5 to
11f80cf
Compare
Collaborator
Author
Updated the description of the PR. |
cmwarrington
approved these changes
Jun 24, 2026
jaschdoc
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates KSP to consume sources.kotlin.all instead of sources.kotlin.static (these are both AGP APIs). This ensures KSP can process Kotlin sources generated by other plugins or tasks in the build that are registered with AGP itself.
Since KSP's own generated outputs (both Java and Kotlin) are registered to sources.java, they do not appear in sources.kotlin.all. This avoids introducing circular dependencies while still allowing KSP to consume other generated Kotlin sources.
Fixes #2494