Add tests for getDeclarationsFromPackage across multiple rounds - #3183
Merged
Conversation
…rounds This test ensures the getDeclarationsFromPackage function returns the same result across rounds.
This commit updates the inegration test to call getDeclarationsFromPackage across rounds to ensure that the klibs are still accessible after dumping caches between rounds.
jaschdoc
force-pushed
the
multi-round-klibs
branch
from
September 4, 2026 09:41
b5b4d49 to
70de607
Compare
jaschdoc
marked this pull request as ready for review
September 4, 2026 10:16
jaschdoc
enabled auto-merge
September 4, 2026 11:49
troelsbjerre
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KSP drops its AA caches across rounds to ensure new files are correct indexed. Issue #2396 was recently closed, but these tests assert that declarations in packages in klibs are still accessible across rounds, i.e., the cache drops do not affect the
Resolver.getDeclarationsFromPackagefunction.Related to #2396