gainmapmath: write green channel in RGB888 output - #443
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
DichenZhang1
approved these changes
Aug 14, 2026
DichenZhang1
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for finding and fixing this bug!
Contributor
Author
|
@DichenZhang1 thank you and the team for all these great enhancements and ongoing support of this critical library for HDR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pixel.gto the green byte inputRgb888Pixel().Why
putRgb888Pixel()currently writespixel.rto both the red and green bytes. AnyRGB888 output where red and green differ is therefore color-corrupted. Writing the
actual green component preserves the requested RGB pixel values.
Testing
GainMapMathTest.PutRgb888PixelWritesGreenChannel; it fails on current mainand passes with this change.
combinations skipped.