Avoid authorizing incorrectly on HTTP 302 redirect#58
Merged
Conversation
The sample & common way of verifying a specific user is authenticated is to use curl to check if a certain http query completes correctly. The -f or --fail flag passed to curl ensures zero vs non zero exit code based on http code. Unfortunately there is a corner case where a http redirect (302 status code) is by default not followed by curl AND it returns a zero exit code, accidentally considering any badge swipe valid. This is especially problematic as many cloud services, including AppEngine have set up an automatic redirect from http to https, making it so that a typo of http instead of https might accidentally make any badge swipe authenticate. This change adds the -L flag to the sample .ini which will instruct curl to follow redirects instead of returning on http status code 302.
brianbeck-google
approved these changes
Mar 25, 2026
Collaborator
|
Please sync to HEAD and pick up #60 That should fix the build failures. |
Collaborator
|
I cloned this locally, rebased, and confirmed that lint/test still pass: https://github.com/brianbeck-google/makerspace-auth/tree/jvg58 Given that this change is comment-only this is not surprising. Rebasing and merging as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample & common way of verifying a specific user is authenticated is to use curl to check if a certain http query completes correctly.
The -f or --fail flag passed to curl ensures zero vs non zero exit code based on http code.
Unfortunately there is a corner case where a http redirect (302 status code) is by default not followed by curl AND it returns a zero exit code, accidentally considering any badge swipe valid.
This is especially problematic as many cloud services, including AppEngine have set up an automatic redirect from http to https, making it so that a typo of http instead of https might accidentally make any badge swipe authenticate.
This change adds the -L flag to the sample .ini which will instruct curl to follow redirects instead of returning on http status code 302.