ci: implement workflow_run pattern for coverage comments#51
Conversation
- Moves PR commenting to a separate privileged workflow to support forks. - Ensures coverage data is archived even on build failure. - Uses explicit file existence checks for reliable comment posting.
Summary of ChangesHello @g-husam, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the continuous integration process by enhancing how code coverage comments are generated and posted, particularly for contributions from forks. It also improves the project's packaging metadata and adopts a dynamic versioning strategy, leading to a more robust and maintainable development workflow. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request title and description describe CI workflow changes (implementing the workflow_run pattern, archiving coverage data, and adding file existence checks), but the provided code changes only modify pyproject.toml to implement dynamic versioning via setuptools-scm and add project metadata. This discrepancy should be resolved to maintain a clear project history. Technically, the transition to dynamic versioning is well-implemented, though adding a fallback version for setuptools-scm and including authors metadata would improve the package's robustness and completeness for distribution.
I am having trouble creating individual review comments. Click here to see my feedback.
pyproject.toml (22)
As you are adding project metadata for distribution, it is recommended to include the authors field in the [project] section as per PEP 621. This provides essential information for package consumers and registry displays.
dynamic = [ "version" ]
authors = [
{ name = "Google LLC" },
]
pyproject.toml (24)
The changes in this PR (implementing dynamic versioning and adding project metadata) do not align with the PR title and description, which focus on CI workflow improvements for coverage comments. Please update the PR metadata to reflect the actual changes or ensure that the intended CI configuration files are included in this PR.
pyproject.toml (133)
Consider adding a fallback_version for setuptools-scm. This prevents build failures when the project is installed from a source distribution that does not include the .git directory (e.g., a ZIP download from GitHub). This can be configured by adding a [tool.setuptools_scm] section with fallback_version = "0.0.0".
Uh oh!
There was an error while loading. Please reload this page.