Fix domain page "not found" layout issue - #2474
Merged
Merged
Conversation
jianglai
approved these changes
Jun 7, 2024
jianglai
left a comment
jianglai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
ptkach
enabled auto-merge
June 7, 2024 14:29
ptkach
disabled auto-merge
June 7, 2024 14:30
ptkach
force-pushed
the
consoleDomainPageFixes
branch
2 times, most recently
from
June 7, 2024 14:57
e2cd2bd to
c00bcdc
Compare
ptkach
force-pushed
the
consoleDomainPageFixes
branch
from
June 7, 2024 18:29
c00bcdc to
a664788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing in alpha I noticed some regression in layout introduced by #2457 . This PR repairs the regression.
This change is