Skip to content

Chage run-time of DeleteExpiredDomainsAction#2801

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:deleteTiming
Aug 12, 2025
Merged

Chage run-time of DeleteExpiredDomainsAction#2801
gbrodman merged 1 commit into
google:masterfrom
gbrodman:deleteTiming

Conversation

@gbrodman

@gbrodman gbrodman commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

We probably want this to run before the billing recurrence expansion pipeline just in case there are any domains that should be deleted before their billing recurrence gets expanded.


This change is Reviewable

@gbrodman
gbrodman requested a review from ptkach August 12, 2025 18:58

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion


core/src/main/java/google/registry/config/files/tasks/cloud-scheduler-tasks-sandbox.xml line 116 at r1 (raw file):

      autorenew end date.
    </description>
    <schedule>30 2 * * *</schedule>

Great idea! I checked and it looks like this task usually takes under a minute. Given that I think it'd make sense to move it even closer to expandBillingRecurrences, maybe 2.45 ? And I'd live a comment in both places to hint that timing is related

We probably want this to run before the billing recurrence expansion
pipeline just in case there are any domains that should be deleted
before their billing recurrence gets expanded.

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @ptkach)


core/src/main/java/google/registry/config/files/tasks/cloud-scheduler-tasks-sandbox.xml line 116 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

Great idea! I checked and it looks like this task usually takes under a minute. Given that I think it'd make sense to move it even closer to expandBillingRecurrences, maybe 2.45 ? And I'd live a comment in both places to hint that timing is related

Done.

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gbrodman)

@gbrodman
gbrodman enabled auto-merge August 12, 2025 20:09
@gbrodman
gbrodman added this pull request to the merge queue Aug 12, 2025
Merged via the queue into google:master with commit 8c1e0ff Aug 12, 2025
9 checks passed
@gbrodman
gbrodman deleted the deleteTiming branch August 12, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants