Add rdeEppParams to RDE output#3041
Conversation
| - **FakeClock and Sleeper:** Use `FakeClock` and `Sleeper` for any logic involving timeouts, delays, or expiration. | ||
| - **Empirical Reproduction:** Before fixing a bug, always create a test case that reproduces the failure. | ||
| - **Base Classes:** Leverage `CommandTestCase`, `EppToolCommandTestCase`, etc., to reduce boilerplate and ensure consistent setup (e.g., clock initialization). | ||
| - **Gradle Test Patterns:** Whenever running tests in the "core" directory, try to use the "standardTest" Gradle task instead of "test". Just "test" includes the "fragileTest" task which can add a lot of time. |
There was a problem hiding this comment.
I think this instruction might be worded a little bit too strongly? We do indeed want to run fragileTest, at least some of the time. Sure, run standardTest first, because if one of those is failing then it'll be found quicker, but even if that is passing, we do still want the AI to run all tests before it thinks the code change is overall successful.
There was a problem hiding this comment.
sure, we can update that
CydeWeys
left a comment
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).
CydeWeys
left a comment
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).
We mostly had the xsd code for this already, we just never actually used it and added it to the output. Note that I had to make some changes to allow the expected format (where some of the elements are empty).
2 participants
We mostly had the xsd code for this already, we just never actually used it and added it to the output. Note that I had to make some changes to allow the expected format (where some of the elements are empty).
This change is