Use cache for RDAP searches for host by superord domain - #3145
Merged
Conversation
gbrodman
force-pushed
the
rdapSubordinateHostSearch
branch
4 times, most recently
from
July 13, 2026 16:12
a0402e8 to
1dfcd33
Compare
weiminyu
approved these changes
Jul 15, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
this allows us to only do one query instead of looping over the hosts and doing queries one by one, while still leveraging the cache.
gbrodman
force-pushed
the
rdapSubordinateHostSearch
branch
from
July 16, 2026 19:39
1dfcd33 to
e2f8c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows us to only do one query instead of looping over the hosts and doing queries one by one, while still leveraging the cache.
This change is