Skip to content

[bls-signatures] Initial integration#5641

Merged
jonathanmetzman merged 6 commits intogoogle:masterfrom
guidovranken:bls-signatures
Apr 22, 2021
Merged

[bls-signatures] Initial integration#5641
jonathanmetzman merged 6 commits intogoogle:masterfrom
guidovranken:bls-signatures

Conversation

@guidovranken
Copy link
Contributor

Differential fuzzing of 3 BLS signature libraries

BLS signatures are a critical security feature in cryptocurrency clients, such as:

  • Ethereum 2.0
  • Chia
  • DFinity
  • Filecoin

If this project is accepted, I will add more auto_cc's later.

@AdamKorcz
Copy link
Collaborator

Could you adjust the title of the PR to suggest this is an initial integration?

@guidovranken
Copy link
Contributor Author

@AdamKorcz I've addressed the issues you raised.

The CI says the UBSAN build fails the build check, but I cannot reproduce this locally.

@guidovranken guidovranken changed the title [bls-signatures] [bls-signatures] Initial integration Apr 22, 2021
@AdamKorcz
Copy link
Collaborator

I tried this locally. The broken build reproduces with the following steps:

  1. sudo python3 infra/helper.py pull_images
  2. sudo python3 infra/helper.py build_image bls-signatures
  3. sudo python3 infra/helper.py build_fuzzers bls-signatures --engine libfuzzer --sanitizer undefined --architecture x86_64
  4. sudo python3 infra/helper.py check_build bls-signatures --engine libfuzzer --sanitizer undefined --architecture x86_64 <- Build error happens here.

@AdamKorcz
Copy link
Collaborator

I followed the steps taken in my last comment but with the build file from the first commit in this PR (which passed CI), and the same errors were encountered during the check_build step.

@guidovranken
Copy link
Contributor Author

I tried this locally. The broken build reproduces with the following steps:

1. `sudo python3 infra/helper.py pull_images`

2. `sudo python3 infra/helper.py build_image bls-signatures`

3. `sudo python3 infra/helper.py build_fuzzers bls-signatures --engine libfuzzer --sanitizer undefined --architecture x86_64`

4. `sudo python3 infra/helper.py check_build bls-signatures --engine libfuzzer --sanitizer undefined --architecture x86_64` <- Build error happens here.

I repeated your steps verbatim (after doing a docker system prune -a) and cannot reproduce. I've disabled the UBSAN build for now.

@AdamKorcz
Copy link
Collaborator

Great. This one is ready for review @oliverchang @jonathanmetzman @inferno-chromium @asraa

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 65a87b5 into google:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants