Skip to content

fix(vulnfeeds): prevent duplicate events in database_specific#5593

Merged
jess-lowe merged 2 commits into
google:masterfrom
jess-lowe:fix/db-dupes
Jul 6, 2026
Merged

fix(vulnfeeds): prevent duplicate events in database_specific#5593
jess-lowe merged 2 commits into
google:masterfrom
jess-lowe:fix/db-dupes

Conversation

@jess-lowe

Copy link
Copy Markdown
Contributor

combine-to-osv merges database_specific fields using MergeDatabaseSpecificValues from the conversion package. However, the helper function deduplicateList only checked comparable basic types (strings, ints, floats, bools). Non-comparable types (like maps representing JSON objects) were always appended without deduplication.

I updated deduplicateList to check if a type is comparable. If it's not (e.g. a map or slice), it now checks for uniqueness against previously observed uncomparable elements using reflect.DeepEqual.

@jess-lowe jess-lowe requested a review from another-rex July 6, 2026 01:39
another-rex
another-rex previously approved these changes Jul 6, 2026
@jess-lowe jess-lowe merged commit 6117ff7 into google:master Jul 6, 2026
26 checks passed
@jess-lowe jess-lowe deleted the fix/db-dupes branch July 6, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants