feat: repo-based consider all branches - #5797
Open
Ly-Joey wants to merge 1 commit into
Open
Conversation
Ly-Joey
marked this pull request as ready for review
August 6, 2026 01:46
another-rex
reviewed
Aug 6, 2026
| } | ||
|
|
||
| urlCache := make(map[string]struct{}) | ||
| regexCache := make([]*regexp.Regexp, 0) |
Contributor
There was a problem hiding this comment.
We can make this a global cache to avoid recompiling even when the cache expires.
michaelkedar
reviewed
Aug 6, 2026
Comment on lines
+133
to
+140
| if entry.Value == "" { | ||
| continue | ||
| } | ||
| re, err := regexp.Compile(entry.Value) | ||
| if err != nil { | ||
| // Skip invalid regex entries. | ||
| continue | ||
| } |
Member
There was a problem hiding this comment.
We should probably log a warning or something if it's invalid so we can see if we messed up our regexes
Comment on lines
+213
to
+215
| if err != nil { | ||
| return false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add repo-based consider all branches logic in worker before we send the request to gitter to enumerate affected commits.
The allowlist is in datastore.