Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions go/internal/worker/pipeline/purl/purl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ func TestEnricher_Enrich(t *testing.T) {
initialPurl: "",
expectedPurl: "pkg:deb/debian/curl?arch=source&distro=bullseye",
},
{
name: "Generate Packagist PURL with repository",
ecosystem: "Packagist:https://packages.drupal.org/8",
pkgName: "drupal/commerce_guest_registration",
initialPurl: "",
expectedPurl: "pkg:composer/drupal/commerce_guest_registration?repository_url=https:%2F%2Fpackages.drupal.org%2F8",
},
}

for _, tc := range tests {
Expand Down
51 changes: 51 additions & 0 deletions go/purl/ecosystem_packagist.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
package purl

import (
"strings"

"github.com/ossf/osv-schema/bindings/go/osvconstants"
packageurl "github.com/package-url/packageurl-go"
)

const repositoryURLQualifier = "repository_url"

//nolint:gochecknoinits // init is used here to register the ecosystem with the global PURL registry.
func init() {
registerGenerator(osvconstants.EcosystemPackagist, generatorFunc(packagistGenerator))
registerParser("composer", "", parserFunc(packagistParser))
}

func packagistGenerator(ecosystem, packageName string) (packageurl.PackageURL, error) {
purl, err := (slashGenerator{purlType: "composer"}).generate(ecosystem, packageName)
if err != nil {
return packageurl.PackageURL{}, err
}

_, repositoryURL, hasRepository := strings.Cut(ecosystem, ":")
if hasRepository && repositoryURL != "" {
purl.Qualifiers = packageurl.Qualifiers{
{Key: repositoryURLQualifier, Value: repositoryURL},
}
}

return purl, nil
}

func packagistParser(purl packageurl.PackageURL) (packageName string, ecosystem string, err error) {
packageName, ecosystem, err = (simpleParser{
ecosystem: osvconstants.EcosystemPackagist,
joinNamespace: true,
}).parse(purl)
if err != nil {
return "", "", err
}

for _, qualifier := range purl.Qualifiers {
if qualifier.Key == repositoryURLQualifier && qualifier.Value != "" {
ecosystem += ":" + qualifier.Value
break
}
}

return packageName, ecosystem, nil
}
1 change: 0 additions & 1 deletion go/purl/ecosystems_simple.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ func init() {
registerSimple(osvconstants.EcosystemJulia, "julia", "", nil)
registerSimple(osvconstants.EcosystemNuGet, "nuget", "", nil)
registerSimple(osvconstants.EcosystemOSSFuzz, "generic", "", nil)
registerSlash(osvconstants.EcosystemPackagist, "composer")
registerSimple(osvconstants.EcosystemPub, "pub", "", nil)
registerSimple(osvconstants.EcosystemPyPI, "pypi", "", nil)
registerSimple(osvconstants.EcosystemRubyGems, "gem", "", nil)
Expand Down
33 changes: 33 additions & 0 deletions go/purl/purl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,36 @@ func TestParse(t *testing.T) {
}
}
}

func TestPackagistRepositoryRoundTrip(t *testing.T) {
const (
ecosystem = "Packagist:https://packages.drupal.org/8"
packageName = "drupal/commerce_guest_registration"
wantPURL = "pkg:composer/drupal/commerce_guest_registration?repository_url=https:%2F%2Fpackages.drupal.org%2F8"
)

gotPURL, err := Generate(ecosystem, packageName)
if err != nil {
t.Fatalf("Generate(%q, %q) returned an error: %v", ecosystem, packageName, err)
}
if gotPURL != wantPURL {
t.Fatalf("Generate(%q, %q) = %q, want %q", ecosystem, packageName, gotPURL, wantPURL)
}

gotEcosystem, gotPackage, gotVersion, err := Parse(gotPURL)
if err != nil {
t.Fatalf("Parse(%q) returned an error: %v", gotPURL, err)
}
if gotEcosystem != ecosystem || gotPackage != packageName || gotVersion != "" {
t.Errorf(
"Parse(%q) = (%q, %q, %q), want (%q, %q, %q)",
gotPURL,
gotEcosystem,
gotPackage,
gotVersion,
ecosystem,
packageName,
"",
)
}
}
Loading