tp: remove the standalone traceconv binary - #6410
Merged
LalitMaganti merged 1 commit intoAug 3, 2026
Merged
Conversation
LalitMaganti
commented
Jun 29, 2026
🎨 Perfetto UI Builds
|
safayat-google
approved these changes
Jun 29, 2026
safayat-google
left a comment
safayat-google
left a comment
Member
There was a problem hiding this comment.
LGTM.
I think the migration is completely backward compatible. We can still update some of the documentation to use the trace processor shell command instead.
-
docs/contributing/build-instructions.md:
Removetraceconvfrom the list of standalone build targets.
Direct developers to buildtrace_processor_shellinstead. -
[Optional]
docs/quickstart/traceconv.md(ordocs/toc.md):
Update command syntax tables fromtraceconvMODEtotrace_processorSUBCOMMAND.
Explain thattraceconvfunctionality is now built directly intotrace_processor. -
[Optional]
docs/getting-started/linux-cookbook.md&docs/getting-started/cpu-profiling.md:
Update references totraceconvbundle andtraceconvprofile.
Member
Author
Yes I have some followup CLs which will take care of all this. |
LalitMaganti
changed the base branch from
main
to
dev/lalitm/docs-point-trace-conversion-docs-at-trace_processor
August 3, 2026 09:31
LalitMaganti
force-pushed
the
dev/lalitm/tp-remove-the-standalone-traceconv-binary
branch
from
August 3, 2026 09:32
4a2f96d to
8d2f609
Compare
LalitMaganti
force-pushed
the
dev/lalitm/tp-remove-the-standalone-traceconv-binary
branch
from
August 3, 2026 09:34
8d2f609 to
24ffab6
Compare
Base automatically changed from
dev/lalitm/docs-point-trace-conversion-docs-at-trace_processor
to
main
August 3, 2026 09:59
LalitMaganti
force-pushed
the
dev/lalitm/tp-remove-the-standalone-traceconv-binary
branch
from
August 3, 2026 10:05
24ffab6 to
b7b1d73
Compare
LalitMaganti
force-pushed
the
dev/lalitm/tp-remove-the-standalone-traceconv-binary
branch
from
August 3, 2026 10:08
b7b1d73 to
4b949d6
Compare
LalitMaganti
deleted the
dev/lalitm/tp-remove-the-standalone-traceconv-binary
branch
August 3, 2026 10:31
sashwinbalaji
added a commit
that referenced
this pull request
Aug 3, 2026
Partial revert of 2d5a0c7 (#6410). Downstream build targets still depend on the standalone traceconv binary (e.g. //third_party/perfetto:traceconv in google3, which is breaking the autoroll), so restore it while those callers migrate to trace_processor_shell. Reverted: - src/traceconv/{main,traceconv}.cc, include/perfetto/ext/traceconv and the executable/main/traceconv_lib GN targets. src/traceconv:lib is now linked by both traceconv and trace_processor_shell. - src/traceconv/wasm_main.cc is dropped; the UI's traceconv WASM module goes back to being built from traceconv.cc. - The bundle CLI test moves back to src/traceconv/traceconv_bundle_integrationtest.cc. - Release plumbing: the LUCI recipe, package-github-release-artifacts, gen_android_bp and gen_bazel, plus the regenerated Android.bp and bazel BUILD. Not reverted: - python/tools/{cpu_profile,heap_profile}.py and the amalgamated tools/{cpu_profile,heap_profile}. #6410 pointed these back at the traceconv prebuilt and its flat MODE arguments, which fixes a real issue independent of this revert: both manifests are pinned at the v57.2 release, and the v57.2 trace_processor_shell prebuilt predates the convert/util subcommands, so `trace_processor_shell util symbolize` fails against the binary the scripts download. The traceconv-name compat shim in src/trace_processor/shell is left in place: it came from #6400, not #6410, so trace_processor_shell keeps accepting traceconv-style command lines when invoked under that name.
sashwinbalaji
added a commit
that referenced
this pull request
Aug 3, 2026
) Partial revert of 2d5a0c7 (#6410). Downstream build targets still depend on the standalone traceconv binary (e.g. //third_party/perfetto:traceconv in google3, which is breaking the autoroll), so restore it while those callers migrate to trace_processor_shell. Reverted: - src/traceconv/{main,traceconv}.cc, include/perfetto/ext/traceconv and the executable/main/traceconv_lib GN targets. src/traceconv:lib is now linked by both traceconv and trace_processor_shell. - src/traceconv/wasm_main.cc is dropped; the UI's traceconv WASM module goes back to being built from traceconv.cc. - The bundle CLI test moves back to src/traceconv/traceconv_bundle_integrationtest.cc. - Release plumbing: the LUCI recipe, package-github-release-artifacts, gen_android_bp and gen_bazel, plus the regenerated Android.bp and bazel BUILD. Not reverted: - python/tools/{cpu_profile,heap_profile}.py and the amalgamated tools/{cpu_profile,heap_profile}. #6410 pointed these back at the traceconv prebuilt and its flat MODE arguments, which fixes a real issue independent of this revert: both manifests are pinned at the v57.2 release, and the v57.2 trace_processor_shell prebuilt predates the convert/util subcommands, so `trace_processor_shell util symbolize` fails against the binary the scripts download. The traceconv-name compat shim in src/trace_processor/shell is left in place: it came from #6400, not #6410, so trace_processor_shell keeps accepting traceconv-style command lines when invoked under that name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
traceconv is now trace_processor_shell, so delete the binary:
src/traceconv/{main,traceconv}.cc, the public header, and the
executable/main/traceconv_lib targets. The conversion code
(src/traceconv:lib) stays and is linked by the shell. Drop traceconv from
the release plumbing too: the LUCI recipe, the GitHub packager and
gen_android_bp.
The UI only needs format conversion, and pulling the whole shell into the
WASM would drag in rpc/httpd that doesn't build under Emscripten. So the
WASM keeps a small conversion-only entry point (wasm_main.cc) over
src/traceconv:lib; the worker args and the WASM output name don't change.
The bundle CLI test moves to bundle_integrationtest.cc and drives
TraceProcessorShellMain.
The recipe expectation files still need
recipes.py test train, whichneeds cipd and couldn't be run here.