Google sync#220
Merged
Merged
Conversation
This doesn't seem to have fixed the flaky test, but it seems like a good thing to do anyway. PiperOrigin-RevId: 226243994
Fixes main_test.Pytype.testBuiltinsDeterminism3, which was failing ~half of the time with a complaint that __builtin__ and six.moves.builtins were being pickled non-deterministically. PiperOrigin-RevId: 226374183
Once importlab PRs 42-44 land, the graph that pytype gets from importlab will include both unreadable Python files and type stubs. Thus, we can stop special-casing unreadable files in main (since pytype will analyze them normally and report a syntax error) and need to filter out .pyi and .pytd files in pytype_runner. The fact that pytype sees type stubs now will make it easier to implement #151. Also bumps the version number in order to do a release. Fixes #212. PiperOrigin-RevId: 226556520
martindemello
approved these changes
Dec 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.