fix(site): restore scrolling so the landing demo stays reachable - #280
Merged
Conversation
The landing page demo (asciinema, 185x69 cast) fills the container width (~900px) and renders ~780px tall, but body overflow: hidden blocked all scrolling, so the bottom of the demo was permanently clipped and unreachable. Switch the landing body to overflow-x: hidden so vertical scrolling is available again and the full demo is always reachable.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the landing page styling by moving inline styles for the #demo-player element in site/layouts/index.html to the project's SCSS file (_styles_project.scss), and changes the main container's overflow property to overflow-x: hidden. Feedback was provided to use align-items: safe center to prevent layout clipping when the content height exceeds the viewport height.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hello! This is a fix to the landing page demo being cut off at the bottom and unreachable.
The bottom of the demo was clipped out due to
overflow: hiddenon the body even on scroll.Changes
overflow: hidden→overflow-x: hidden— restores vertical scrolling