Skip to content

Add testbed for CVE-2025-0868#139

Merged
copybara-service[bot] merged 5 commits into
google:mainfrom
frkngksl:docsgptRCE
Sep 9, 2025
Merged

Add testbed for CVE-2025-0868#139
copybara-service[bot] merged 5 commits into
google:mainfrom
frkngksl:docsgptRCE

Conversation

@frkngksl

Copy link
Copy Markdown
Contributor

Hello

This is a testbed for CVE-2025-0868

Issue is: google/tsunami-security-scanner-plugins#651

@tooryx tooryx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frkngksl,

Are files missing? This PR does not seem to contain the docker images you mention in the README. Nor the setup.sh.

Could you please take a look?

Thanks,
~tooryx

@frkngksl

frkngksl commented Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

Hi @tooryx ,

The bash script downloads the official release source code as a zip file, and that zip file contains the mentioned docker files (including the files that are used to build the image).

If you want, I can remove the file download step, and put the source code zip directly here.

@tooryx

tooryx commented Jul 8, 2025

Copy link
Copy Markdown
Member

Hi @frkngksl,

It seems like the local version of the deployment (https://github.com/arc53/DocsGPT/blob/main/deployment/docker-compose-local.yaml) can be used. If that is the case, I would recommend:

What do you think?

Thank you,
~tooryx

@frkngksl

frkngksl commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

Hi @tooryx ,

Okay, I will make these changes . In the mean time, you can test the plugin by installing this with the current bash script right?

Thanks

@frkngksl

frkngksl commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

Hi @tooryx ,

It seems like the local version of the deployment (https://github.com/arc53/DocsGPT/blob/main/deployment/docker-compose-local.yaml) can be use

The above docker-compose-local.yaml cannot be used to verify this vulnerability, because it only uses frontend container. We are using the following docker-compose.yaml

https://github.com/arc53/DocsGPT/blob/0.12.0/docker-compose.yaml

Since there are five distinct containers (3 of them will be built) in this compose file, doing what you recommend (seperate edited dockerfiles, cloning repository one by one, although worker is using the same build file with backend etc.) can make this setup process more complicated. What do you think? If you want I can put the source code here directly with a suitable .env file so that just running docker-compose would be enough to setup the testbed. (But remember that the current install.sh script downloads it and does the same thing by calling the official DocsGPT setup.sh script)

Best regards,

@tooryx

tooryx commented Jul 9, 2025

Copy link
Copy Markdown
Member

Hi @frkngksl,

Here is my proposal: Just replace the content with a README file, and provide the following instructions.

  1. Git clone the repository https://github.com/arc53/DocsGPT/
  2. For the vulnerable version git checkout 0.12.0 otherwise git checkout 0.13.0
  3. echo -e "LLM_PROVIDER=docsgpt\nVITE_API_STREAMING=true" > .env
  4. Run docker-compose up --build at the root of the repository

I think it makes things way simpler. The setup.sh script at the root of the repository does not provide much value for our use case.

Ideally, in the future we might want to use docker-in-docker to produce one composed image that is reproducible. We will see later.

Let me know your thoughts.

~tooryx

@frkngksl

frkngksl commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Hi @tooryx ,

That docker-in-docker idea sounds awesome. Okay, I will make the changes that you suggested today, and ping you when it is ready.

Best regards,

@frkngksl

frkngksl commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Hi @tooryx ,

Made the changes and tested the commands.

@frkngksl frkngksl closed this Aug 21, 2025
@frkngksl
frkngksl deleted the docsgptRCE branch August 21, 2025 06:47
@frkngksl
frkngksl restored the docsgptRCE branch August 21, 2025 06:49
@frkngksl frkngksl reopened this Aug 21, 2025
@frkngksl

frkngksl commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

Hi @tooryx ,

Found another forgotten one, in case you want to merge it to the master, just wanted to inform you.

Best regards,

@copybara-service
copybara-service Bot merged commit 594236f into google:main Sep 9, 2025
3 checks passed
@frkngksl
frkngksl deleted the docsgptRCE branch September 9, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants