Sync #pragma shader_stage(<stage>) to -fshader-stage=<stage> - #1575
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I think it's a bad idea to make new conventions for shader stage names that are aliases of existing names. Let's stick to the conventions in Glslang: Also, updates like this should come with tests. |
dneto0
left a comment
There was a problem hiding this comment.
see comments on the main part of this PR
Thanks for your response. But it's not the new aliases. Actually it's the same as custom pragma directives of shaderc (in libshaderc_util/src/shader_stage.cc), such as |
Ah, I see. It's been so long I forgot about the
I'll build on top of this to add tests. (I'll push to your tree, thanks for allowing maintainers to edit). |
dneto0
left a comment
There was a problem hiding this comment.
with the new tests i added, this LGTM.
Thanks for your patience.
Sorry and it slipped my mind about adding test suit. Thank you for your review and merge. |
This PR synchronizes the shader stages flags for the
-fshader-stage=option with the#pragma shader_stage(<stage>)list inglslc/src/main.cc. Such asraygen,closest, etc.