Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ private Fact actualContents() {
/** Ordered implementation that does nothing because an earlier check already caused a failure. */
private static final Ordered ALREADY_FAILED = () -> {};

// TODO: b/246961366 - Do we want to override + deprecate isEqualTo/isNotEqualTo?
// TODO(b/246961366): Do we want to override + deprecate isEqualTo/isNotEqualTo?

// TODO(user): Do we want to support comparingElementsUsing() on StreamSubject?
}
Original file line number Diff line number Diff line change
Expand Up @@ -2061,7 +2061,7 @@ public final void containsNoneOf(E first, E second, E... rest) {
* Checks that the actual iterable contains no elements that correspond to any of the given
* elements.
*/
@SuppressWarnings("nullness") // TODO: b/423853632 - Remove after checker is fixed.
@SuppressWarnings("nullness") // TODO(b/423853632): Remove after checker is fixed.
public void containsNoneIn(Iterable<? extends E> excluded) {
if (actual == null) {
failWithActual(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ private Fact actualContents() {
/** Ordered implementation that does nothing because an earlier check already caused a failure. */
private static final Ordered ALREADY_FAILED = () -> {};

// TODO: b/246961366 - Do we want to override + deprecate isEqualTo/isNotEqualTo?
// TODO(b/246961366): Do we want to override + deprecate isEqualTo/isNotEqualTo?

// TODO(user): Do we want to support comparingElementsUsing() on StreamSubject?
}
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ private UsingCorrespondence(
* Checks that the actual multimap contains an entry with the given key and a value that
* corresponds to the given value.
*/
@SuppressWarnings("nullness") // TODO: b/423853632 - Remove after checker is fixed.
@SuppressWarnings("nullness") // TODO(b/423853632): Remove after checker is fixed.
public void containsEntry(@Nullable Object key, E value) {
Entry<Object, E> entry = immutableEntry(key, value);
if (actual == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ static <E> ImmutableList<E> sandwich(E first, E[] array, E last) {
return expected == null ? asList((E) null) : asList(expected);
}

// TODO: b/316358623 - Inline this helper method after fixing our nullness checker to not need it.
// TODO(b/316358623): Inline this helper method after fixing our nullness checker to not need it.
@SuppressWarnings("nullness") // the aforementioned checker bug
static <E extends @Nullable Object> List<E> asList(E... a) {
return Arrays.asList(a);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ public void serialization_comparisonFailureWithFacts() {
(ComparisonFailure) makeComparisonFailure(messages, facts, expected, actual, cause);

ComparisonFailure reserializedFailure = reserialize(original);
// TODO: b/491194734 - Remove this redundant cast once Kotlin header compilation permits.
// TODO(b/491194734): Remove this redundant cast once Kotlin header compilation permits.
ErrorWithFacts reserialized = (ErrorWithFacts) ((AssertionError) reserializedFailure);
assertThat(reserializedFailure).hasMessageThat().isEqualTo(original.getMessage());
assertThat(reserializedFailure).hasCauseThat().hasMessageThat().isEqualTo(cause.getMessage());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ public void tolerance_compare_negativeTolerance() {

@Test
/*
* TODO: b/136037484 - Make tolerance() return false instead of throwing? Declare it with
* TODO(b/136037484): Make tolerance() return false instead of throwing? Declare it with
* @Nullable types even though it throws?
*/
@J2ktIncompatible
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,7 @@ public String toString() {
}

@Test
@J2ktIncompatible // TODO: b/420703524 - Detect the Kotlin/Native default toString() output
@J2ktIncompatible // TODO(b/420703524): Detect the Kotlin/Native default toString() output
public void withNoToStringOverride() {
Iterable<Integer> iterable = () -> Iterators.forArray(1, 2, 3);

Expand Down
Loading