Skip to content

Add missing glslc argument "--target-env=vulkan1.1"#53

Merged
dneto0 merged 1 commit into
google:mainfrom
nirs:linux
Apr 9, 2026
Merged

Add missing glslc argument "--target-env=vulkan1.1"#53
dneto0 merged 1 commit into
google:mainfrom
nirs:linux

Conversation

@nirs

@nirs nirs commented Jun 1, 2025

Copy link
Copy Markdown
Contributor

All the benchmarks use this expect compute and matmul, which fail to compile, complamning that SPIR-V 1.3 is required. If we dont' specity the target we use vulkan-1.0 which default to SPIR-V 1.0.

 glslc -h
 ...
  --target-env=<environment>
		    Set the target client environment, and the semantics
		    of warnings and errors.  An optional suffix can specify
		    the client version.  Values are:
			vulkan1.0       # The default
			vulkan1.1
			vulkan1.2
			vulkan1.3
			vulkan1.4
			vulkan          # Same as vulkan1.0
			opengl4.5
			opengl          # Same as opengl4.5
  --target-spv=<spirv-version>
		    Set the SPIR-V version to be used for the generated SPIR-V
		    module.  The default is the highest version of SPIR-V
		    required to be supported for the target environment.
		    For example, default for vulkan1.0 is spv1.0, and
		    the default for vulkan1.1 is spv1.3,
		    the default for vulkan1.2 is spv1.5,
		    the default for vulkan1.3 is spv1.6,
		    the default for vulkan1.4 is spv1.6.
		    Values are:
			spv1.0, spv1.1, spv1.2, spv1.3, spv1.4, spv1.5, spv1.6

All the benchmarks use this expect compute and matmul, which fail to
compile, complamning that SPIR-V 1.3 is required. If we dont' specity
the target we use vulkan-1.0 which default to SPIR-V 1.0.

     glslc -h
     ...
	  --target-env=<environment>
			    Set the target client environment, and the semantics
			    of warnings and errors.  An optional suffix can specify
			    the client version.  Values are:
				vulkan1.0       # The default
				vulkan1.1
				vulkan1.2
				vulkan1.3
				vulkan1.4
				vulkan          # Same as vulkan1.0
				opengl4.5
				opengl          # Same as opengl4.5
	  --target-spv=<spirv-version>
			    Set the SPIR-V version to be used for the generated SPIR-V
			    module.  The default is the highest version of SPIR-V
			    required to be supported for the target environment.
			    For example, default for vulkan1.0 is spv1.0, and
			    the default for vulkan1.1 is spv1.3,
			    the default for vulkan1.2 is spv1.5,
			    the default for vulkan1.3 is spv1.6,
			    the default for vulkan1.4 is spv1.6.
			    Values are:
				spv1.0, spv1.1, spv1.2, spv1.3, spv1.4, spv1.5, spv1.6
@nirs

nirs commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

ping

@RichardYCJ

Copy link
Copy Markdown

Hi @nirs, just wondering why this PR is frozen? I also need this target-env flag for my PR to work 😄

@nirs

nirs commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Hi @nirs, just wondering why this PR is frozen? I also need this target-env flag for my PR to work 😄

The project seems to be abandoned, there is no activity since #51 was merged.

@dneto0

dneto0 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Thank you. Sorry for the delay. Yes, this project is essentially dormant.

@dneto0
dneto0 merged commit b91e955 into google:main Apr 9, 2026
@nirs
nirs deleted the linux branch April 9, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants