Add missing glslc argument "--target-env=vulkan1.1"#53
Merged
Conversation
All the benchmarks use this expect compute and matmul, which fail to
compile, complamning that SPIR-V 1.3 is required. If we dont' specity
the target we use vulkan-1.0 which default to SPIR-V 1.0.
glslc -h
...
--target-env=<environment>
Set the target client environment, and the semantics
of warnings and errors. An optional suffix can specify
the client version. Values are:
vulkan1.0 # The default
vulkan1.1
vulkan1.2
vulkan1.3
vulkan1.4
vulkan # Same as vulkan1.0
opengl4.5
opengl # Same as opengl4.5
--target-spv=<spirv-version>
Set the SPIR-V version to be used for the generated SPIR-V
module. The default is the highest version of SPIR-V
required to be supported for the target environment.
For example, default for vulkan1.0 is spv1.0, and
the default for vulkan1.1 is spv1.3,
the default for vulkan1.2 is spv1.5,
the default for vulkan1.3 is spv1.6,
the default for vulkan1.4 is spv1.6.
Values are:
spv1.0, spv1.1, spv1.2, spv1.3, spv1.4, spv1.5, spv1.6
Contributor
Author
|
ping |
|
Hi @nirs, just wondering why this PR is frozen? I also need this target-env flag for my PR to work 😄 |
Contributor
Author
dneto0
approved these changes
Apr 9, 2026
Collaborator
|
Thank you. Sorry for the delay. Yes, this project is essentially dormant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the benchmarks use this expect compute and matmul, which fail to compile, complamning that SPIR-V 1.3 is required. If we dont' specity the target we use vulkan-1.0 which default to SPIR-V 1.0.