Conversation
justinfagnani
approved these changes
Oct 20, 2022
| export class ServiceScriptExecution extends BaseExecution<ServiceScriptConfig> { | ||
| static execute( | ||
| config: ServiceScriptConfig, | ||
| script: ServiceScriptConfig, |
There was a problem hiding this comment.
did you mean to go back to script?
Member
Author
There was a problem hiding this comment.
Oops, no, merge mistake. But this whole method is removed in the next commit anyway so no point fixing.
aomarks
pushed a commit
that referenced
this pull request
Jan 10, 2024
In #471 the handling of unhandled exceptions was removed. This adds that missing handling back so that any exceptions that aren't caught can be gracefully handled and raised to the user correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refactoring which allows scripts to directly access full
Executioninstances, instead of just fingerprints as before.This is useful for the lazy startup/shutdown feature of services, because other scripts need to not only get the service's fingerprint, but also to have a
startmethod they can call once they eventually decide whether they need to run or not.Also:
Upgraded the self-signed TLS certificate we use in tests, because after upgrading my Linux distro and/or my Node version, these tests were failing locally due to the key being too weak.
Renamed
scripttoconfigin a few places to remove ambiguity.Use
_foostyle forprotectedmethods.Enabled
noImplicitOverridetsc flagPart of #33