Conversation
justinfagnani
approved these changes
Oct 21, 2022
| */ | ||
| protected async _startServices(): Promise<Result<void, Failure[]>> { | ||
| if (this._config.services.length > 0) { | ||
| const results = await Promise.all( |
There was a problem hiding this comment.
Is Promise.all() ok here (over Promise.allSettled()) because you have your own error results that resolved to, not rejected?
Member
Author
There was a problem hiding this comment.
Yeah we throw only as a panic for an internal error, so in general we don't need to catch exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates services into standard scripts (though note services don't yet actually do anything, that's coming up next). Summary:
Before a standard script runs, all of its services must have started. If any service failed to start, we fail.
While a standard script is still running, if any of its services unexpectedly shuts down, then we're in an invalid state and fail too.
Part of #33