Services: Continue to show output of stale services during watch mode shutdown - #500
Merged
Conversation
justinfagnani
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if we were shutting down a service in watch mode because either its fingerprint changed, or it was removed from the script graph, then during the time the service was shutting down, we wouldn't display its stdout/stderr.
That was because we "detached" it before killing it, but detaching also includes removing the stdout/stderr listeners from the previous execution. It makes more sense to instead go through the existing
abortprocess, and onlydetachwhen we are actually adopting a child into a new execution.Part of #33