Create simulator settings panel. - #271
Merged
Merged
Conversation
Collaborator
|
Great features to add on! Would you move the down arrows a bit left? I started a thread to discuss in depth internally. |
ruofeidu
approved these changes
May 11, 2026
This is a breaking change which deletes the simulator mode indicator. Instead, now the simulator interaction mode is controlled via the settings panel. Currently, there is still only one living room environment. 1. Added Simulator Settings Panel (SimulatorSettingsPanel.ts): Implemented a Lit component (<xrblocks-simulator-settings>) that shows a settings button at the bottom left of the page and opens a glassmorphic panel with dropdowns for AR Simulation Environment and Interaction Mode. 2. Refactored Simulator Configuration (SimulatorOptions.ts): Replaced legacy single-path properties (scenePath, scenePlanesPath, videoPath) with an extensible environments: SimulatorEnvironment[] list supporting multiple simulation environments. 3. Dynamic Environment Switching (SimulatorScene.ts, SimulatorWorld.ts): Updated core components to read from the active environment configuration and added runtime scene reloading capabilities (setEnvironment). 4. Deleted Legacy Mode Indicator (ModeIndicator.ts): Completely removed the old mode indicator component and its associated configuration options.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change which deletes the simulator mode indicator. Instead, now the simulator interaction mode is controlled via the settings panel. Currently, there is still only one living room environment.
<xrblocks-simulator-settings>) that shows a settings button at the bottom left of the page and opens a glassmorphic panel with dropdowns for AR Simulation Environment and Interaction Mode.