fix AI.generate dispatch + isAvailable check - #345
Merged
Conversation
AI.generate forwarded 4 args to this.model!.generate, but OpenAI.generate takes 0 args and throws 'Wrapper not implemented'. with OpenAI configured, calling xb.ai.generate would just throw the wrapper error and the signature mismatch silently passes type-check via the loose abstract base. mirrors the dispatch pattern just added to AI.query: check isAvailable first, branch on the model, throw a clear error for backends that don't support it.
dli7319
force-pushed
the
fix/ai-generate-dispatch
branch
from
June 5, 2026 20:02
73e5d2b to
fa9930b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you've got OpenAI configured,
xb.ai.generate(...)just throws 'Wrapper not implemented' because OpenAI'sgeneratetakes 0 args. same dispatch as #343, bail early for backends that don't do generate.