Skip to content

feat: implement missing features in ui, added test coverage, and revise logs - #359

Merged
ruofeidu merged 8 commits into
google:mainfrom
ruofeidu:main
Jun 11, 2026
Merged

feat: implement missing features in ui, added test coverage, and revise logs#359
ruofeidu merged 8 commits into
google:mainfrom
ruofeidu:main

Conversation

@ruofeidu

Copy link
Copy Markdown
Collaborator
  1. implemented onHover for TextButtons
  2. add key check for Gemini Canvas
  3. add support of npm run test:coverage

also manually tested all AI cases.

…se logs

1. implemented onHover for TextButtons
2. add key check for Gemini Canvas
3. add support of `npm run test:coverage`

also manually tested all AI cases.
@ruofeidu
ruofeidu requested a review from dli7319 June 11, 2026 04:23
@ruofeidu ruofeidu added the sdk Pull requests that update SDK label Jun 11, 2026
Comment thread src/ui/components/TextButton.ts Outdated
Comment thread src/utils/utils.ts Outdated
Comment thread src/core/Core.ts Outdated
Comment thread src/core/Core.ts
@ruofeidu

Copy link
Copy Markdown
Collaborator Author

I reverted the suggestion of adding undefined to get renderer since we have too many places assuming renderer is ready. I think adding a console warning is already useful in case of accidentally fetching renderer without init.

@ruofeidu

Copy link
Copy Markdown
Collaborator Author

Thanks for the double checking!

@ruofeidu
ruofeidu merged commit 3e48932 into google:main Jun 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk Pull requests that update SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants