JSDOM Headless Testing - #399
Merged
Merged
Conversation
dli7319
approved these changes
Jun 20, 2026
ruofeidu
approved these changes
Jun 20, 2026
| button.onTriggered = () => { | ||
| game.spawnItem(); | ||
| }; | ||
| button.position.set(0, 1.2, -1.2); // Positioned in front of camera |
Collaborator
There was a problem hiding this comment.
there is xb.user.height defaults to 1.5 if I remembered.
try avoid magic numbers for 1.2 and -1.2
Collaborator
Author
There was a problem hiding this comment.
This was just an arbitrary test scene but i moved it to core.user.height just to avoid a magic number
| const scores = this.recognizer.recognize(context); | ||
| const pinch = scores['pinch']; | ||
| if (pinch) { | ||
| this.pinchDetected = pinch.confidence > 0.6; |
Collaborator
There was a problem hiding this comment.
explain magic number 0.6
Collaborator
Author
There was a problem hiding this comment.
refactored to test the gesture event detection of the scene over the confidence levels of the recognizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New addon to allow for more functional tests in
addons/testing. IncludesTestRunner.tswhich instantiates all the mock systems needed to startup a test JSDOM run.addons/testing/examples.test.tsshows how tests can be used and extend beyond just logic tests right now.