Add mouse wheel scaling for ModelViewers in the simulator - #437
Merged
dli7319 merged 1 commit intoJul 17, 2026
Merged
Conversation
Collaborator
Collaborator
|
Hi Yong-yuan, For XR, user's viewport is fixed by device... so we likely don't want to mount mouse wheels to camera forwards and backwards, can you make it apply to two-hands-pinch-zoom in and zoom out? Thanks! |
ruofeidu
requested changes
Jul 15, 2026
ruofeidu
left a comment
Collaborator
There was a problem hiding this comment.
Change mouse wheel to scale ModelViewers.
Contributor
Author
|
@ruofeidu Sry, I misunderstood the intended behavior. I’ll update the implementation so the mouse wheel scales the |
Yong-yuan-X
force-pushed
the
agent/issue-428-simulator-wheel-zoom
branch
from
July 16, 2026 06:18
9fd70a2 to
d8a17c2
Compare
dli7319
force-pushed
the
agent/issue-428-simulator-wheel-zoom
branch
from
July 17, 2026 16:37
d8a17c2 to
4add933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelViewerunder the mouse pointer with the wheel in simulator User mode.ModelVieweris targeted.Motivation
The simulator did not provide a mouse-based equivalent of the two-hand pinch gesture used to scale
ModelViewerobjects.Mouse wheel input should change the targeted model's scale without moving the simulator camera or changing the user's viewport.
Testing
npm run test— 58 test files and 493 tests passed on Node.js 24npm run lintnpm run format:checknpm run buildcd docs && npm run buildCloses #428