Updated pre-commit shell script#655
Merged
bwendling merged 1 commit intogoogle:masterfrom Jan 14, 2019
mmphego:master
Merged
Conversation
bwendling
reviewed
Dec 5, 2018
vapier
suggested changes
Dec 6, 2018
vapier
suggested changes
Dec 6, 2018
vapier
suggested changes
Dec 20, 2018
Contributor
Author
|
Ready to merge - Updated script. |
vapier
suggested changes
Dec 27, 2018
Contributor
Author
|
Ready to merge - Updated script. |
Member
|
Could you squash all of the commits into one? It's hard to review them right now. |
Updated shebang from `#!/bin/bash` to `#!/usr/bin/env bash` for portability(https://en.wikipedia.org/wiki/Shebang_%28Unix%29#Portability) related issues. Double quote to prevent globbing and word splitting. Using `command -v` instead of `which`: The reason to select the former over the latter is that it avoids a dependency on something that is outside your shell. Signed-off-by: Mpho Mphego <mpho112@gmail.com>
Contributor
Author
My apologies - I have since updated the PR. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#!/bin/bashto#!/usr/bin/env bashfor portability related issues.command -vinstead ofwhich: The reason to select the former over the latter is that it avoids a dependency on something that is outside your shell.Signed-off-by: Mpho Mphego mpho112@gmail.com