Skip to content

[anneal] Keep vendored Lake inputs older than archive caches#3443

Merged
joshlf merged 1 commit into
mainfrom
Gqbvdpe5hujures6czytfxm2bfeoeddlx
Jun 7, 2026
Merged

[anneal] Keep vendored Lake inputs older than archive caches#3443
joshlf merged 1 commit into
mainfrom
Gqbvdpe5hujures6czytfxm2bfeoeddlx

Conversation

@joshlf
Copy link
Copy Markdown
Member

@joshlf joshlf commented Jun 7, 2026

The installed Nix-built toolchain archive is read-only, and generated verification workspaces symlink vendored .lake/build directories back into that archive to avoid copying several GiB of prebuilt Lean artifacts per run.

Normalize copied vendored Lake source/config mtimes to the Unix epoch so Lake --old treats the linked archive cache artifacts as reusable instead of trying to delete and rebuild read-only .olean files through those symlinks.


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gqbvdpe5hujures6czytfxm2bfeoeddlx && git checkout -b pr-Gqbvdpe5hujures6czytfxm2bfeoeddlx FETCH_HEAD

Checkout

git fetch origin refs/heads/Gqbvdpe5hujures6czytfxm2bfeoeddlx && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gqbvdpe5hujures6czytfxm2bfeoeddlx && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gqbvdpe5hujures6czytfxm2bfeoeddlx

Stacked PRs enabled by GHerrit.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf enabled auto-merge June 7, 2026 00:08
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (88393fc) to head (11bf7f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3443   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The installed Nix-built toolchain archive is read-only, and generated verification workspaces symlink vendored .lake/build directories back into that archive to avoid copying several GiB of prebuilt Lean artifacts per run.

Normalize copied vendored Lake source/config mtimes to the Unix epoch so Lake --old treats the linked archive cache artifacts as reusable instead of trying to delete and rebuild read-only .olean files through those symlinks.

gherrit-pr-id: Gqbvdpe5hujures6czytfxm2bfeoeddlx
@joshlf joshlf force-pushed the Gqbvdpe5hujures6czytfxm2bfeoeddlx branch from d95dbca to 11bf7f7 Compare June 7, 2026 00:20
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf added this pull request to the merge queue Jun 7, 2026
@joshlf joshlf removed this pull request from the merge queue due to a manual request Jun 7, 2026
@joshlf joshlf merged commit 4a2fde1 into main Jun 7, 2026
230 of 233 checks passed
@joshlf joshlf deleted the Gqbvdpe5hujures6czytfxm2bfeoeddlx branch June 7, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants