Preserve Ref pointer metadata - #3626
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
==========================================
+ Coverage 91.85% 91.97% +0.11%
==========================================
Files 20 20
Lines 6093 6142 +49
==========================================
+ Hits 5597 5649 +52
+ Misses 496 493 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dec7f157b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1dec7f1 to
0b44b24
Compare
The Ref constructors that accept an explicit DST element count validated that count, but later typed access reconstructed metadata from the byte length. Dynamic trailing padding can make multiple element counts share one size, so that reconstruction could produce an out-of-bounds slice. Store the validated element count in Ref, preserve it through clone and copy, and supply it to every typed conversion. Add regressions covering ambiguous sizes, zero metadata, all constructor shapes, and mutable access. Closes #3618 *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* gherrit-pr-id: G6hu7kutzboxwmxwxpomxgjcpawysonqg
0b44b24 to
a90604a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The Ref constructors that accept an explicit DST element count validated that
count, but later typed access reconstructed metadata from the byte length.
Dynamic trailing padding can make multiple element counts share one size, so
that reconstruction could produce an out-of-bounds slice.
Store the validated element count in Ref, preserve it through clone and copy,
and supply it to every typed conversion. Add regressions covering ambiguous
sizes, zero metadata, all constructor shapes, and mutable access.
Closes #3618
Authored by an AI agent acting on Josh Liebow-Feeser's behalf.
Latest Update: v3 — Compare vs v2
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G6hu7kutzboxwmxwxpomxgjcpawysonqg && git checkout -b pr-G6hu7kutzboxwmxwxpomxgjcpawysonqg FETCH_HEADCheckout
git fetch origin refs/heads/G6hu7kutzboxwmxwxpomxgjcpawysonqg && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G6hu7kutzboxwmxwxpomxgjcpawysonqg && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.