Reject derive inputs that capture generated helpers - #3635
Conversation
Derive expansions copy user syntax into generated scopes and refer to helper items by unqualified names. Reject uninspectable syntax, contextual `Self`, and identifiers that could change the meaning of copied fields or generated safety checks. Pin the Syn grammar used by this validation and add cross-toolchain regressions for helper capture, copied macros, qualified paths, and enum tag validation. Closes #3633 *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* gherrit-pr-id: Gkiogbp7b2w7nxwx27s7vk5wesojtk7bn
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gifjr6pbpu4fh6t7qbzuuqczj3odny3ck #3635 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Derive expansions copy user syntax into generated scopes and refer to helper
items by unqualified names. Reject uninspectable syntax, contextual
Self,and identifiers that could change the meaning of copied fields or generated
safety checks.
Pin the Syn grammar used by this validation and add cross-toolchain
regressions for helper capture, copied macros, qualified paths, and enum tag
validation.
Closes #3633
Authored by an AI agent acting on Josh Liebow-Feeser's behalf.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gkiogbp7b2w7nxwx27s7vk5wesojtk7bn && git checkout -b pr-Gkiogbp7b2w7nxwx27s7vk5wesojtk7bn FETCH_HEADCheckout
git fetch origin refs/heads/Gkiogbp7b2w7nxwx27s7vk5wesojtk7bn && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gkiogbp7b2w7nxwx27s7vk5wesojtk7bn && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.