Skip to content

Fix JSR global types and update size limits#1371

Closed
dahiya001rohit wants to merge 2 commits intogoogle:mainfrom
dahiya001rohit:main
Closed

Fix JSR global types and update size limits#1371
dahiya001rohit wants to merge 2 commits intogoogle:mainfrom
dahiya001rohit:main

Conversation

@dahiya001rohit
Copy link
Copy Markdown

This update addresses an issue where global type definitions were missing when consuming the package via JSR.

Key Changes:

Fixed JSR Types (src/globals-jsr.ts): Added explicit declare global type definitions. This ensures that users consuming the package via JSR will receive the correct global types, resolving the TODO in
src/globals.ts

Updated Build Config (tsconfig.json): Modified the exclusion rules to exclude
src/globals-jsr.ts instead of src/globals.ts
. This ensures that globals.d.ts is correctly generated for the standard NPM build while preventing "Duplicate identifier" errors during local development. Adjusted Size Limits (.size-limit.json): Slightly increased the allowed package size limits (Libdefs: 44KB, All: 907KB) to accommodate the additional type definitions and prevent build failures.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@antongolub
Copy link
Copy Markdown
Collaborator

antongolub commented Jan 27, 2026

declare global remains restricted in JSR
https://jsr.io/docs/about-slow-types#global-augmentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants