Transform exceptions on server streaming calls.#349
Merged
nwbirnie merged 3 commits intogoogleads:masterfrom Oct 8, 2020
nwbirnie:callable
Merged
Transform exceptions on server streaming calls.#349nwbirnie merged 3 commits intogoogleads:masterfrom nwbirnie:callable
nwbirnie merged 3 commits intogoogleads:masterfrom
nwbirnie:callable
Conversation
jradcliff
requested changes
Oct 6, 2020
Currently we do not generate GoogleAdsException instances for server streaming callables (see #332) Change-Id: Ia8339f1ee482ab7f02085f5c47f90ab1cc0aee5b
Change-Id: I6993862c9427e6678b1b3ab00a041cbea5383fd7
Contributor
Author
|
Sorry for the force push, forgot that messes up git's review history. |
jradcliff
reviewed
Oct 7, 2020
jradcliff
reviewed
Oct 7, 2020
Change-Id: If3fef16448c9f6497dbe0a8ae97946d92a47adbb
jradcliff
approved these changes
Oct 8, 2020
devchas
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we do not generate GoogleAdsException instances for server streaming callables (see #332). This means that users cannot retrieve the GoogleAdsFailure objects when streaming calls fail.
This change adds an ExceptionTransformingServerStreamingCallable class which handles the exception transformation. It also adds unit tests for both the new and the existing ExceptionTransformingUnaryCallable classes.
The remaining callable types will be handled in a follow up CL.
Change-Id: Ia8339f1ee482ab7f02085f5c47f90ab1cc0aee5b