-
Notifications
You must be signed in to change notification settings - Fork 185
Transform exceptions on server streaming calls. #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
google-ads/src/main/java/com/google/ads/googleads/lib/callables/ExceptionTransformation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Copyright 2020 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.ads.googleads.lib.callables; | ||
|
|
||
| /** Represents a transformation between {@link Throwable}s. */ | ||
| public interface ExceptionTransformation { | ||
|
|
||
| /** | ||
| * Transforms an input throwable to an output throwable. | ||
| * | ||
| * <p>If no transformation is applied this must return the input throwable. | ||
| */ | ||
| Throwable transform(Throwable throwable); | ||
| } | ||
81 changes: 81 additions & 0 deletions
81
.../com/google/ads/googleads/lib/callables/ExceptionTransformingServerStreamingCallable.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| // Copyright 2020 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.ads.googleads.lib.callables; | ||
|
|
||
| import com.google.api.gax.rpc.ApiCallContext; | ||
| import com.google.api.gax.rpc.ApiException; | ||
| import com.google.api.gax.rpc.ResponseObserver; | ||
| import com.google.api.gax.rpc.ServerStreamingCallable; | ||
| import com.google.api.gax.rpc.StreamController; | ||
|
|
||
| /** | ||
| * Wrapper around a {@link ServerStreamingCallable} which invokes an {@link ExceptionTransformation} | ||
| * for {@link Throwable}s which occur on the stream. | ||
| * | ||
| * <p>NOTE: This class could be pushed into the gax library, as it is not specific to the Google Ads | ||
| * API. | ||
| */ | ||
| public class ExceptionTransformingServerStreamingCallable<RequestT, ResponseT> | ||
| extends ServerStreamingCallable<RequestT, ResponseT> { | ||
|
|
||
| private final ServerStreamingCallable<RequestT, ResponseT> innerCallable; | ||
| private final ExceptionTransformation exceptionTransformation; | ||
|
|
||
| public ExceptionTransformingServerStreamingCallable( | ||
| ServerStreamingCallable<RequestT, ResponseT> innerCallable, | ||
| ExceptionTransformation exceptionTransformation) { | ||
| this.innerCallable = innerCallable; | ||
| this.exceptionTransformation = exceptionTransformation; | ||
| } | ||
|
|
||
| @Override | ||
| public void call( | ||
| RequestT request, ResponseObserver<ResponseT> responseObserver, ApiCallContext context) { | ||
| innerCallable.call(request, new ExceptionTransformingStreamObserver(responseObserver), context); | ||
| } | ||
|
|
||
| /** Provides a mechanism for transforming any exceptions which occur on the stream. */ | ||
| private class ExceptionTransformingStreamObserver implements ResponseObserver<ResponseT> { | ||
|
nwbirnie marked this conversation as resolved.
Outdated
|
||
|
|
||
| private final ResponseObserver<ResponseT> innerObserver; | ||
|
|
||
| public ExceptionTransformingStreamObserver(ResponseObserver<ResponseT> innerObserver) { | ||
| this.innerObserver = innerObserver; | ||
| } | ||
|
|
||
| @Override | ||
| public void onStart(StreamController controller) { | ||
| innerObserver.onStart(controller); | ||
| } | ||
|
|
||
| @Override | ||
| public void onResponse(ResponseT response) { | ||
| innerObserver.onResponse(response); | ||
| } | ||
|
|
||
| @Override | ||
| public void onError(Throwable t) { | ||
| if (t instanceof ApiException) { | ||
| t = exceptionTransformation.transform(t); | ||
| } | ||
| innerObserver.onError(t); | ||
| } | ||
|
|
||
| @Override | ||
| public void onComplete() { | ||
| innerObserver.onComplete(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.