NameError: name 'six' is not defined

[razvanbalosin]

There appears to be a reference to six which was removed in a previous commit [Removal of Python 2 support (#188)] in google/ads/google_ads/v2/services/enums.py

Which is throwing an error when accessing enums without the client. i.e.

from google.ads.google_ads.v2.services.enums import AdvertisingChannelTypeEnum
AdvertisingChannelTypeEnum.AdvertisingChannelType.SEARCH

File ".../google/ads/google_ads/v2/services/enums.py", line 88, in __getattribute__
    six.exec_(class_def_src, {'enum': enum},
NameError: name 'six' is not defined

[razvanbalosin]

Documentation lacks a bit around enum usage and I'm just trying to figure out the proper way to work with them.
Should we always use the GoogleAdsClient to handle enums? If so, is this the right approach?

For example, on the AdvertisingChannelTypeEnum, SEARCH = 2

# Get enum int value -- return int 2
client.get_type('AdvertisingChannelTypeEnum', version='v2').SEARCH

# Get enum int value from text dynamically -- return int 2
client.get_type('AdvertisingChannelTypeEnum', version='v2').AdvertisingChannelType.Value('SEARCH')

# Get enum text value from enum int dynamically -- return 'SEARCH'
client.get_type('AdvertisingChannelTypeEnum', version='v2').AdvertisingChannelType.Name(2)

[wihl]

The reference to six is an error, which we will address shortly. The first method is the preferred method that is used in the code examples.

[j-walker23]

@wihl just making sure it's not my setup. Has the six error been released?

[wihl]

It has not been released yet. There is a significant update to this library in a couple of weeks which incorporate this change as well as several other things.

[j-walker23]

Very good, thanks for the update.

…

On Thu, Feb 13, 2020 at 7:53 AM David Wihl ***@***.***> wrote: It has not been released yet. There is a significant update to this library in a couple of weeks which incorporate this change as well as several other things. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#199?email_source=notifications&email_token=AAPM4RMXISHCLZCALW3GS5TRCVNH5A5CNFSM4KCARQ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELVIKLY#issuecomment-585794863>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPM4ROWTRYY5A2NSMPLE2TRCVNH5ANCNFSM4KCARQ3Q> .

[BenRKarl]

@j-walker23 I'll look into the six error, I don't think it was incorporated into the recent releases.

In general it's definitely preferable to use the client to access Enums, as in your second example. The reason is that the code underneath google.ads.google_ads.v2 is generated and the structure could change, however we'll always make sure the client interface is consistent.

Also your second snippet on Enum usage is correct. It's clunky but right now that's the best way to access data on Enums. We're working on an improvement to this interface, (see: #110) and are really eager to get it out because the current interface is definitely awkward.

[j-walker23]

@BenRKarl this specific six error is fixed for me since the 5.x release

[BenRKarl]

@j-walker23 you don't see an error when running the below?:

from google.ads.google_ads.v2.services.enums import AdvertisingChannelTypeEnum
AdvertisingChannelTypeEnum.AdvertisingChannelType.SEARCH

[j-walker23]

@BenRKarl I had updated to v3 before ever trying anything.
I had little to none required code changes to update so it was quick and easy (thank you for that!).

Do you need me to go down to v2 and check?