Added type hints to examples/audience_insights #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobhancockg
changed the title
This commit introduces type hints for function arguments, return values, and local variables in `examples/audience_insights/generate_audience_insights.py`. Key changes include: - Added type hints to all function signatures and return types. - Added inline type hints for variables within functions. - Imported necessary types from `typing`, Google Ads client libraries, services, enums, and types modules. - Ensured proper organization and removal of unused or duplicate imports. - Updated some variable assignments to use specific Enum members for clarity (e.g., `AudienceInsightsDimensionEnum`). - Replaced some string formatting with f-strings in exception handling. These changes improve code readability, maintainability, and help with static analysis, making your example code more robust and easier to understand.
BenRKarl
force-pushed
the
add-type-hints-audience-insights
branch
from
89e0688 to
5f38c69
Compare
BenRKarl
approved these changes
Jul 21, 2025
BenRKarl
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces type hints for function arguments, return values, and local variables in
examples/audience_insights/generate_audience_insights.py.Key changes include:
typing, Google Ads client libraries, services, enums, and types modules.AudienceInsightsDimensionEnum).These changes improve code readability, maintainability, and help with static analysis, making your example code more robust and easier to understand.