Remove JSON serialization of Proto messages#95
Merged
Merged
Conversation
…est/response objects
…cessful responses are not serialized
… .format for log string
wihl
reviewed
May 2, 2019
wihl
left a comment
wihl
left a comment
Contributor
There was a problem hiding this comment.
This is mainly a syntactic and formatting review. I haven't yet tested the functionality. I'll be able to give a more thorough check in a couple of days and will file an issue if I find anything.
AnashOommen
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Serialization of fields such as
video_quartile_25_ratethat contain a digit following an underscore will raise errors in Python.This is expected behavior because it's not possible to serialize from snake_case to camelCase and back when a digit follows an underscore.
The fields in the API that contain this pattern are technically breaking this convention, but until a broader resolution is arrived at it's easier for now to simply not serialize messages to JSON for the purposes of logging because proto objects serialize to string very well on their own already.
This PR also introduces some general refactoring and cleanup.