Add type hints to examples/shopping_ads #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundquist
requested changes
May 28, 2025
BenRKarl
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
BenRKarl
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This change adds type annotations to all Python files within the examples/shopping_ads directory. Type hints were added for function arguments, return values, class attributes, and local variables to improve code clarity, maintainability, and enable static analysis.
Changed import paths from google.ads.googleads.v17 to google.ads.googleads.v20 and updated GoogleAdsClient.load_from_storage to use version='v20'.
BenRKarl
force-pushed
the
add-type-hints-shopping-ads
branch
from
5fc7b4b to
2eb243a
Compare
Change-Id: I836105786063f23d40941a8f8f1986d3d48e2253
BenRKarl
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds type annotations to all Python files within the examples/shopping_ads directory.
Type hints were added for function arguments, return values, class attributes, and local variables to improve code clarity, maintainability, and enable static analysis.